Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

a11y: accessibility issue 2022 #2741

Merged
cwhitten merged 4 commits into from
Apr 23, 2020
Merged

a11y: accessibility issue 2022 #2741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e600be
fix accessibility issue 2022
liweitian Apr 22, 2020
33e3791
Merge branch 'master' into accessibility2022-2
liweitian Apr 23, 2020
7e96f13
Merge branch 'master' into accessibility2022-2
beyackle Apr 23, 2020
1dd06d1
Merge branch 'master' into accessibility2022-2
cwhitten Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Composer/packages/client/src/components/Header/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import composerIcon from '../../images/composerIcon.svg';
import { AppUpdaterStatus } from '../../constants';
import { StoreContext } from '../../store';

import { updateAvailableIcon, headerContainer, title, botName } from './styles';
import { updateAvailableIcon, headerContainer, title, botName, divider } from './styles';

export const Header = props => {
const {
Expand All @@ -34,8 +34,9 @@ export const Header = props => {
aria-label={formatMessage('Composer Logo')}
src={composerIcon}
/>
<span css={title}>{formatMessage('Bot Framework Composer')}</span>
<span css={botName}>{props.botName}</span>
<div css={title}>{formatMessage('Bot Framework Composer')}</div>
<div css={divider} />
<div css={botName}>{props.botName}</div>
{showUpdateAvailableIcon && (
<IconButton
iconProps={{ iconName: 'History' }}
Expand Down
30 changes: 12 additions & 18 deletions Composer/packages/client/src/components/Header/styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,38 +9,32 @@ export const headerContainer = css`
position: relative;
background: ${NeutralColors.black};
height: 50px;
line-height: 50px;
display: flex;
flex-direction: row;
align-items: center;
`;

export const title = css`
position: relative;
margin-left: 25px;
font-weight: ${FontWeights.semibold};
font-size: 16px;
color: #fff;
bottom: 11px;
&::after {
content: '';
position: absolute;
top: 0px;
right: -15px;
bottom: 11px;
width: 0px;
height: 24px;
border: none;
border-right: 1px solid #979797;
border-image: initial;
outline: none;
}
min-width: 200px;
`;

export const botName = css`
position: absolute;
margin-left: 30px;
margin-left: 15px;
font-size: 16px;
word-break: break-all;
color: #fff;
`;

export const divider = css`
height: 24px;
border-right: 1px solid #979797;
margin: 0px 0px 0px 4px;
`;

export const updateAvailableIcon = {
icon: {
color: '#FFF',
Expand Down
2 changes: 1 addition & 1 deletion Composer/packages/client/src/pages/home/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export const page = css`
display: flex;
overflow-x: hidden;
overflow-y: auto;
flex-wrap: wrap;
`;

export const leftPage = css`
Expand Down Expand Up @@ -58,7 +59,6 @@ export const newBotContainer = css`
`;

export const leftContainer = css`
min-width: 535px;
margin-top: 10px;
margin-bottom: 10px;
flex: auto;
Expand Down