This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Open a bot through bfcomposer protocol#2706
Merged
Conversation
srinaath
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
srinaath
changed the title
srinaath
changed the title
|
Coverage decreased (-0.3%) to 40.442% when pulling dcbae067d0f08f3c1fa214d2e1cdf4e24ddba2c6 on srravich/electron-2323-open-bot into 3558910 on master. |
cwhitten
previously approved these changes
Apr 20, 2020
Member
|
@srinaath can you address conflicts? |
Contributor
Author
added 5 commits
April 20, 2020 14:31
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Safe commit for electron Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Test windows installer Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Logs remove Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Reset commits Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> All commits with logs Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Refactored Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Mac working Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Safe commit for Mac and Wimdows Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Code cleanup Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Wrapping up open API Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Revert back to original server Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
force-pushed
the
srravich/electron-2323-open-bot
branch
from
dcbae06 to
eb70946
Compare
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
cwhitten
approved these changes
Apr 20, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to open a bot in composer through the bfcomposer protocol.
For ex
bfcomposer://open?url=bot%2F88524.65932484581%2Fdialogs%2Fdeleteitem%3Fselected%3Dtriggers%5B0%5D%26focused%3Dtriggers%5B0%5D.actions%5B0%5D
translates to
http:localhost:5000/bot/88524.65932484581/dialogs/deleteitem?selected=triggers[0]&focused=triggers[0].actions[0]
Task Item
Fixes #2323
Screenshots