This repository was archived by the owner on Jul 9, 2025. It is now read-only.
a11y: accessibility issue on create new bot dialog#2683
Merged
corinagum merged 3 commits intomicrosoft:masterfrom Apr 17, 2020
Merged
a11y: accessibility issue on create new bot dialog#2683corinagum merged 3 commits intomicrosoft:masterfrom
corinagum merged 3 commits intomicrosoft:masterfrom
Conversation
liweitian
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
liweitian
changed the title
corinagum
approved these changes
Apr 17, 2020
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
looks great, thanks for the catch
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The issue is:
Click the New button on the home page to open the create a new bot dialog
when we choose the option between 'create from template' or 'create from scratch', the screen reader does not announce anything.
And I am sorry I cannot find the related task id (There is one!). So I create one by myself.
Task Item
Refs #2684
Screenshots