This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: support the cross train corner case#2673
Merged
cwhitten merged 10 commits intomicrosoft:masterfrom Apr 21, 2020
Merged
Conversation
lei9444
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
Contributor
|
Looks good to me, @feich-ms can you also help verify the behavior here? |
Contributor
|
@lei9444 issue microsoft/botframework-cli#714 is fixed here microsoft/botframework-cli#714. Maybe you can wait for the fix in and update the bf-lu package then. |
Contributor
Author
|
@boydc2014 @feich-ms I have updated the config and package now. And test it in composer, it works well now. |
Member
|
@lei9444 please address conflicts |
boydc2014
previously approved these changes
Apr 21, 2020
cwhitten
approved these changes
Apr 21, 2020
cwhitten
approved these changes
Apr 21, 2020
beyackle
pushed a commit
to corinagum/BotFramework-Composer
that referenced
this pull request
Apr 21, 2020
* fix: support the cross train corner case * update the unit test * update the config * add config for all other kinds triggers Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
beyackle
pushed a commit
that referenced
this pull request
Apr 22, 2020
* fix: support the cross train corner case * update the unit test * update the config * add config for all other kinds triggers Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* fix: support the cross train corner case * update the unit test * update the config * add config for all other kinds triggers Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix: support the cross train corner case * update the unit test * update the config * add config for all other kinds triggers Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
for beginDialog in OnBeginDialog trigger
main.lu: {dia1.lu: ""}for OnIntent(Name=IntentB) in this trigger, just an SendActivity action
config will be like
main.lu: {'':"IntentB"}ignore the local intent
But the config don't support multiple intent triggers -> 1 dialog now, I have create a issue microsoft/botframework-cli#713
Task Item
refs #2520
Screenshots