This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: render correct field when value is '0'#2666
Merged
cwhitten merged 3 commits intomicrosoft:masterfrom Apr 16, 2020
Merged
Conversation
a-b-r-o-w-n
requested review from
boydc2014,
corinagum and
cwhitten
as code owners
cwhitten
approved these changes
Apr 16, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix issue in one of field when value is 0 * extract utils from expression field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were checking
if (!value)to determine which field type to render. This change hardens that check to only check for undefined or null.Task Item
closes #2658