Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Comments

fix: scroll bar missing and some ux issue#2639

Merged
cwhitten merged 9 commits intomicrosoft:masterfrom
zhixzhan:ux-fix
Apr 15, 2020
Merged

fix: scroll bar missing and some ux issue#2639
cwhitten merged 9 commits intomicrosoft:masterfrom
zhixzhan:ux-fix

Conversation

@zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Apr 14, 2020

Description

  1. fix scroll bar missing in all up view left navigate bar.
  2. fix beenUsed icon should not be interact-able.
  3. for LU all up view beenUsed calculation are no longer explicitly correct, hide this column for now.
  4. fix Luis publish error

Task Item

closes #2603
closes #2633
closes #2595
closes #2532

Screenshots

Screen Shot 2020-04-14 at 4 59 06 PM

a-b-r-o-w-n
a-b-r-o-w-n previously approved these changes Apr 14, 2020
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
image

After:
image

Checkmarks and vertical 'more' button are no longer vertically aligned.

@github-actions
Copy link

Coverage Status

Coverage increased (+0.02%) to 41.529% when pulling 97cb6b4 on zhixzhan:ux-fix into c81949c on microsoft:master.

@zhixzhan
Copy link
Contributor Author

Before:
image

After:
image

Checkmarks and vertical 'more' button are no longer vertically aligned.

updated,
image

@cwhitten cwhitten merged commit a056f53 into microsoft:master Apr 15, 2020
@zhixzhan zhixzhan deleted the ux-fix branch April 28, 2020 08:23
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* been used icon

* temporary disable beenUsed column in LU all up view

* left navbar allow scroll

* filter lu notification error

* update test

* vertical align icon

Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants