This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: FlowEditor edges not shown in Electron container#2638
Merged
Conversation
yeze322
requested review from
a-b-r-o-w-n,
benbrown,
boydc2014,
corinagum,
cwhitten and
luhan2017
as code owners
7 tasks
srinaath
reviewed
Apr 14, 2020
Composer/packages/extensions/visual-designer/src/widgets/SwitchConditionWidget.tsx
Outdated
Show resolved
Hide resolved
Member
|
@yeze322 do you know what is causing E2E to fail? |
Contributor
Author
|
Member
|
Oh I know that, it seems to have been introduced with this change.
…On Wed, Apr 15, 2020 at 7:23 AM zeye ***@***.***> wrote:
@yeze322 <https://github.com/yeze322> do you know what is causing E2E to
fail?
[image: image]
<https://user-images.githubusercontent.com/8528761/79348471-9f592500-7f67-11ea-9d20-3ac7b2593d2c.png>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2638 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI2MYCYSYYVB2PCTFZUVK3RMW7NXANCNFSM4MHR56EQ>
.
|
Contributor
Author
|
@cwhitten the svg is overlapped with action node, cypress cannot click the action title. Setting z-index should fix this issue ----------update I realized that it's not that easy to thoroughtly fix the z-index problem. It's a 3D model The click issue only happens under cypress env, so I fixed it on CI side |
Member
|
ok @yeze322 - thanks! |
cwhitten
approved these changes
Apr 15, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* give SVGContainer dynamic size * + FlowEdges * bypass breadcrumb CI Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #2167
This PR assigns each SVGContainer a same size with its parten container.
Make sure every svg line drawn at proper position.
Reason: Overflowed elements under an
<svg>container will be drawn at improper position (related to zoom rate):Task Item
Screenshots