This repository was archived by the owner on Jul 9, 2025. It is now read-only.
a11y: restructure field labels for better a11y#2631
Merged
Conversation
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Update FieldLabel.tsx * lint stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adjusts FieldLabel.tsx so the SR reads out a sensible label for a field when it ought to and the a11y checker doesn't complain about fields without labels (this used to happen because the "aria-labelledby" attribute referred to an object which only existed while the tooltip was open).
Task Item
closes #2063
closes #2122
Screenshots
SR: "Entities: Required entities - group."
(tab)
SR: "Form editor - new value - edit."
