This repository was archived by the owner on Jul 9, 2025. It is now read-only.
a11y: fix "select" confusion in FileSelector#2591
Merged
Conversation
Contributor
Author
|
I've marked this as a draft until I fix the parallel problem over in the Notification page too. |
Contributor
|
Oops, I'm awful at noticing the draft status. I'll just keep an eye on the status of this one till it's ready. |
Contributor
Author
|
I'm not 100% happy with this fix - it solves the keyboard problem, but activating a file in the selector or going to a problem the Notifications list is showing takes a double-click. This feels intuitive enough in the file list (it's just like file lists work anyway in a typical GUI), but double-clicking a notification doesn't seem intuitive to me. Still, it does fix the bug, so I'm opening this to review. |
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
…BotFramework-Composer into beyackle/fileSelector
corinagum
approved these changes
Apr 9, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix minor issues in FileSelector * Update NotificationList.tsx * Update fileUtil.ts * Update NotificationPage.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes FileSelector so "selecting" a row by moving to it with the arrow keys doesn't result in behavior that should happen when a row is "selected" by clicking/activating it.
Task Item
Fixes #2067
Screenshots