This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: add ability to set code editor settings#2552
Merged
cwhitten merged 23 commits intomicrosoft:masterfrom Apr 8, 2020
Merged
feat: add ability to set code editor settings#2552cwhitten merged 23 commits intomicrosoft:masterfrom
cwhitten merged 23 commits intomicrosoft:masterfrom
Conversation
a-b-r-o-w-n
requested review from
boydc2014,
corinagum and
cwhitten
as code owners
Contributor
cwhitten
approved these changes
Apr 8, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* set up code editor options in client store * add ability to change editor options at runtime * add codeEditorSettings to shell data * wire up code editor settings to lg/lu editors * add userSettings namespace * add ability to resize property editor * allow changing settings in all up views * add minimap to code editor settings * remove settings cog * move code editor settings to preferences page * add ability to change dialog nav width * remove unused import * fix up settings routes * remove dead code * update lockfile * fix onboarding e2e spec * remove cy.wait in favor of asserting on the url * add additional assertion to wait for homepage to load Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Task Item
closes #2385
closes #987
Screenshots