This repository was archived by the owner on Jul 9, 2025. It is now read-only.
a11y: change button to icon in FieldLabel.tsx#2551
Merged
Conversation
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
Member
|
@beyackle can we bump the icon/focus indication over a few pixels to not overlap on top of the label? |
Contributor
Author
|
@cwhitten Will do. |
Contributor
Author
|
Updated spacing.
|
a-b-r-o-w-n
approved these changes
Apr 7, 2020
Contributor
a-b-r-o-w-n
left a comment
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
The callout caret is slightly off-center. Is there a way to align it in the middle? I see this in master too, so if you want to go ahead and merge, that's ok with me.
Composer/packages/extensions/adaptive-form/src/components/FieldLabel.tsx
Show resolved
Hide resolved
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Update FieldLabel.tsx * Update FieldLabel.tsx Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the icon button in FieldLabel with an ordinary Icon (and makes sure it's still in screen-reader tabbable order).
Task Item
Closes #2115
Screenshots
Also just a minor adjustment so the focus rectangle looks better.