Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Comments

fix: add locale to lu cross train config#2542

Merged
cwhitten merged 4 commits intomicrosoft:masterfrom
lei9444:fixcrosstrain
Apr 8, 2020
Merged

fix: add locale to lu cross train config#2542
cwhitten merged 4 commits intomicrosoft:masterfrom
lei9444:fixcrosstrain

Conversation

@lei9444
Copy link
Contributor

@lei9444 lei9444 commented Apr 7, 2020

Description

7972a7e4-168f-4a62-89b4-da430a7d4867

When creating the crossTrain config, The locale was ignored. So the crossTain api can' t find the file and throw the error.

Task Item

refs #2496

Screenshots

@github-actions
Copy link

github-actions bot commented Apr 7, 2020

Coverage Status

Coverage increased (+0.07%) to 40.528% when pulling 761f8fd on lei9444:fixcrosstrain into bc511ba on microsoft:master.

@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Apr 7, 2020
@cwhitten cwhitten merged commit 9027223 into microsoft:master Apr 8, 2020
@lei9444 lei9444 deleted the fixcrosstrain branch April 14, 2020 08:28
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* add locale to lu cross train config

* add some comments

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Approved to merge approved, waiting to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants