This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Setup infrastructure to launch and package Composer as an Electron app#2462
Merged
tonyanziano merged 56 commits intomasterfrom Apr 7, 2020
Merged
feat: Setup infrastructure to launch and package Composer as an Electron app#2462tonyanziano merged 56 commits intomasterfrom
tonyanziano merged 56 commits intomasterfrom
Conversation
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Fixing build for mac Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Removed duplicate Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…Framework-Composer into toanzian/electron2
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…Framework-Composer into toanzian/electron2
…mposer into toanzian/electron2
tonyanziano
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
a-b-r-o-w-n
suggested changes
Apr 6, 2020
Contributor
a-b-r-o-w-n
left a comment
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
There are a bunch of console.logs that can be replaced with the debug package. Other than that, I'm just curious why adding the client as a dependency to the server is necessary?
…Framework-Composer into toanzian/electron2
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…Framework-Composer into toanzian/electron2
a-b-r-o-w-n
reviewed
Apr 7, 2020
…mposer into toanzian/electron2
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Remove eslint Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
a-b-r-o-w-n
previously approved these changes
Apr 7, 2020
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
cwhitten
approved these changes
Apr 7, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…ron app (microsoft#2462) * copy server for custom electron * build: add electron-server to yarn * build(electron-server,client): build client to electron-server * feat(electron-server): add electron app support * Got rid of duplicated server code. * Modified structure to use workspace imports. * Configured dev workflows to work. * Working packaged Windows build. * Working packaged version without excessive copying. * Regenerated lockfile * Updated to working lockfile. * Piggy backed off of master's lockfile * Updated builds Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Fixing build for mac Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Removed duplicate Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Fixed plugin paths. * Electron build system polish * Builds for mac, linux Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Added Mac / Linux paths for dist script. * Added flags to build scripts to produce 64-bit binaries. * Added electron application icons. * Update latest yaml scripts generation for platforms Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Docs updates. * PR polish. * Registering composer as a browser protocol to open it from command line Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Fixed linting errors. * Check if removing bfc client from server stops the error Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Moving workspace dependancies Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Added back client Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Fixed linux icon. * Added back bfc client Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Ensure /client/ is copied to docker container * @BFC client in server now Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Push extensions Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Setting correct path for extensions Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Ensure ui-plugins are copied to docker container. * Change nodeIntegration to false in BrowserWindow config * Adding a Plist file to verify if codesign works Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated plist file name Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Separated electron-builder config out into its own file. * Added trailing newline to `electron-builder-config.json` * Fixed broken script. * Server now waits for the express app to be listening before starting. * Leveraged 'debug' for logging. * Change console.log to log Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Remove eslint Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Resolve lint error Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Chris Anderson <chrande@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR piggybacks off of @christopheranderson's previous work to launch and package Composer as an Electron application.
Highlights of this PR:
electron-serverpackage which is a lightweight wrapper that starts up the Composer web app inside of an Electron shellPlease take a look at
electron-server/README.mdfor information on how to build / run / package Composer Electron locally.Task Item
closes #2224
Screenshots