This repository was archived by the owner on Jul 9, 2025. It is now read-only.
a11y: use formError state in "New Dialog" form#2369
Merged
a-b-r-o-w-n merged 4 commits intomasterfrom Mar 26, 2020
Merged
Conversation
beyackle
changed the title
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
a-b-r-o-w-n
approved these changes
Mar 26, 2020
a-b-r-o-w-n
suggested changes
Mar 26, 2020
Contributor
a-b-r-o-w-n
left a comment
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
One thing that #2338 does which is nice is automatically focus the name field. Can you add that here and then we can merge?
a-b-r-o-w-n
approved these changes
Mar 26, 2020
This was referenced Mar 26, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Update createDialogModal.tsx * Update createDialogModal.tsx * fix typos, add autoFocus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We already have form errors in our state, so we should be able to just clean up our validation code and use existing methods to make them happen every form change and not just on submit.
Task Item
Closes #2060
Closes #2074