This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: show choices when it's typed with string[] or expression#2334
Merged
a-b-r-o-w-n merged 3 commits intomicrosoft:masterfrom Mar 23, 2020
Merged
fix: show choices when it's typed with string[] or expression#2334a-b-r-o-w-n merged 3 commits intomicrosoft:masterfrom
a-b-r-o-w-n merged 3 commits intomicrosoft:masterfrom
Conversation
According to sdk.schema, the 'choices' field of 'Microsoft.ChoiceInput' could be either object list or string list. Make Visual Editor support both of those formats. microsoft#2319
yeze322
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
According to sdk definition, 'choices' could be an expression string.
yeze322
changed the title
a-b-r-o-w-n
approved these changes
Mar 23, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…oft#2334) * fix🐞(uischema): fix choices string According to sdk.schema, the 'choices' field of 'Microsoft.ChoiceInput' could be either object list or string list. Make Visual Editor support both of those formats. microsoft#2319 * fix🐞(uischema):dynamic choices According to sdk definition, 'choices' could be an expression string. Co-authored-by: Andy Brown <asbrown002@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to sdk.schema, the 'choices' field of 'Microsoft.ChoiceInput' could be typed with 3 types:
This PR makes Visual Editor support all of these 3 formats by updating uischema definitions.
closes #2319
Task Item
#2319
Screenshots