Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Comments

chore: '$type' -> '$kind'#2333

Merged
cwhitten merged 13 commits intomasterfrom
schema/kind
Mar 31, 2020
Merged

chore: '$type' -> '$kind'#2333
cwhitten merged 13 commits intomasterfrom
schema/kind

Conversation

@yeze322
Copy link
Contributor

@yeze322 yeze322 commented Mar 23, 2020 •
edited by a-b-r-o-w-n
Loading

⚠️ WARNING: BREAKING CHANGE

This will break existing bots that have $type written. To fix, update all occurrences of $type to $kind. But note that if the bot is on an older version of the runtime (early 4.7 release), the $kind property does not work.

Description

Converts all usage of $type to $kind.

Task Item

closes #2301

@yeze322 yeze322 mentioned this pull request Mar 23, 2020
Closed
@yeze322
Copy link
Contributor Author

yeze322 commented Mar 23, 2020

UT failed because of '@bfc/shared' not updated

@a-b-r-o-w-n a-b-r-o-w-n self-assigned this Mar 23, 2020
@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented Mar 23, 2020

@yeze322 thanks for opening this. As soon as I get the form work merged, I will tackle this.

@github-actions
Copy link

github-actions bot commented Mar 30, 2020

Coverage Status

Coverage decreased (-0.04%) to 39.561% when pulling a1f4ce5 on schema/kind into 6407d7a on master.

@a-b-r-o-w-n a-b-r-o-w-n changed the title '$type' -> '$kind' chore: '$type' -> '$kind' Mar 31, 2020
@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as ready for review March 31, 2020 22:21
@cwhitten cwhitten merged commit dc8be58 into master Mar 31, 2020
@cwhitten cwhitten deleted the schema/kind branch March 31, 2020 22:48
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@yeze322 @a-b-r-o-w-n
chore: '$type' -> '$kind' (microsoft#2333)
953be36 
* refactor🦄(Visual Editor):'$type' to '$kind'

* update extension packages to use $kind

* update client to use $kind

* update server to use $kind

* update other packages to use $kind

* rename SDKTypes to SDKKinds

* update tests to use $kind

* update template bots to use $kind

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

1 more reviewer

@cwhitten cwhitten cwhitten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@a-b-r-o-w-n a-b-r-o-w-n

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yeze322 @a-b-r-o-w-n @cwhitten