Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use ':' instead of '=' for prefix #2275

Merged
merged 4 commits into from
Mar 17, 2020
Merged

fix: use ':' instead of '=' for prefix #2275

merged 4 commits into from
Mar 17, 2020

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Mar 16, 2020 •
edited
Loading

Description

Use : instead of = for prefix

Task Item

closes #2222

Screenshots

image

@github-actions
Copy link

Coverage Status

Coverage decreased (-0.007%) to 40.968% when pulling fca9afb on julong/prefixWithEqual into ad6903d on master.

@cwhitten
Copy link
Member

@alanlong9278 we decided we wanted to keep the expression = sign but replace the assignment operator in the node with :, so:

somval: =somefunc

Can you update this?

cwhitten
cwhitten previously requested changes Mar 16, 2020
View reviewed changes
Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see earlier comment

@alanlong9278
Copy link
Contributor Author

@alanlong9278 we decided we wanted to keep the expression = sign but replace the assignment operator in the node with :, so:

somval: =somefunc

Can you update this?

Sure.

@alanlong9278 alanlong9278 changed the title fix: refine add = prefix logic fix: use ':' instead of '=' for prefix Mar 17, 2020
@boydc2014 boydc2014 merged commit 7e53610 into master Mar 17, 2020
@boydc2014 boydc2014 deleted the julong/prefixWithEqual branch March 17, 2020 08:09
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@cwhitten cwhitten cwhitten left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@yeze322 yeze322 Awaiting requested review from yeze322

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanlong9278 @cwhitten @boydc2014