This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Conversation
liweitian
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
boydc2014
reviewed
Mar 17, 2020
liweitian
force-pushed
the
showDiskName
branch
2 times, most recently
from
97918f5 to
6dd0ff1
Compare
Contributor
|
Looks way better now. |
boydc2014
previously approved these changes
Mar 18, 2020
yeze322
reviewed
Mar 18, 2020
yeze322
previously approved these changes
Mar 19, 2020
Member
|
@liweitian please address conflicts |
Contributor
Author
it is done. |
a-b-r-o-w-n
previously requested changes
Mar 23, 2020
cwhitten
previously requested changes
Mar 25, 2020
Member
cwhitten
left a comment
cwhitten
left a comment
There was a problem hiding this comment.
yarn lint failing with:
| /home/runner/work/BotFramework-Composer/BotFramework-Composer/Composer/packages/client/src/CreationFlow/DefineConversation/index.tsx
| 4:1 error There should be at least one empty line between import groups import/order
cwhitten
approved these changes
Mar 25, 2020
cwhitten
added a commit
that referenced
this pull request
Mar 25, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* add disk names * add disk names * remove console * handle comments * do not allow creating bot in path 'this PC' * handle comments
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
This reverts commit b84ce05.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Task Item
Closes #2257
Screenshots