chore: sync oauth input property in form editor #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanlong9278
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
a-b-r-o-w-n
reviewed
Mar 12, 2020
| @@ -1960,7 +1960,7 @@ export const appschema: OBISchema = { | |||
| description: 'Time out setting for the OAuth signin card.', | |||
| default: '900000', | |||
| }, | |||
| tokenProperty: { | |||
| property: { | |||
| $role: 'expression', | |||
| title: 'Token property', | |||
There was a problem hiding this comment.
Do the other properties need to change? Like title, description, etc?
There was a problem hiding this comment.
There are some additional schema like allowInteruption etc, let's don't change it for R8, because it needs UX update which is too heavy.
luhan2017
approved these changes
Mar 13, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sync oauth input property in form editor. Replace
tokenPropertytopropertyforOAuthInputin form editor appschema.Task Item
fixes #2260
Screenshots