Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: Use header tag for trigger in visual editor #2128

Merged
merged 6 commits into from
Mar 5, 2020
Merged

a11y: Use header tag for trigger in visual editor #2128

merged 6 commits into from
Mar 5, 2020

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Feb 28, 2020 •
edited
Loading

Description

Use header tag for trigger in visual editor

Task Item

fixes #2028

Screenshots

image

@alanlong9278 alanlong9278 changed the base branch from stable to master February 28, 2020 13:22
@github-actions
Copy link

Coverage Status

Coverage remained the same at 42.071% when pulling 42b6516 on julong/headerTag into 8b0510b on master.

yeze322
yeze322 suggested changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@yeze322 yeze322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Ashish described in the issue by saying 'defined under heading tag' should be using <h1>/<h2>/<hi> instead of using span

@alanlong9278 alanlong9278 changed the title chore: Add tag for trigger in visual editor chore: Use header tag for trigger in visual editor Feb 29, 2020
@alanlong9278
Copy link
Contributor Author

What Ashish described in the issue by saying 'defined under heading tag' should be using <h1>/<h2>/<hi> instead of using span

Fixed it.

@cwhitten cwhitten changed the title chore: Use header tag for trigger in visual editor ally: Use header tag for trigger in visual editor Mar 4, 2020
@corinagum corinagum changed the title ally: Use header tag for trigger in visual editor a11y: Use header tag for trigger in visual editor Mar 5, 2020
@cwhitten cwhitten merged commit 8a17c92 into master Mar 5, 2020
@cwhitten cwhitten deleted the julong/headerTag branch March 5, 2020 23:37
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Mar 9, 2020
Merged
@cwhitten cwhitten mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@yeze322 yeze322 yeze322 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@benbrown benbrown Awaiting requested review from benbrown

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alanlong9278 @cwhitten @yeze322