Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lu change don't reflect on form editor #1704

Merged
merged 5 commits into from
Dec 7, 2019

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Dec 5, 2019

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

If this is a bug fix, please describe the root cause and analysis of this problem.

Task Item

Fix #1702

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

@boydc2014
Copy link
Contributor

Approved, and let's wait until @cwhitten to take a look.

@a-b-r-o-w-n
Copy link
Contributor

The root cause here is that the design page is always rendered, so we are not getting the usual react lifecycles. Is there a technical reason that we have to leave the design page rendered on all routes and use css to show/hide it?

@zhixzhan
Copy link
Contributor Author

zhixzhan commented Dec 6, 2019

The root cause here is that the design page is always rendered, so we are not getting the usual react lifecycles. Is there a technical reason that we have to leave the design page rendered on all routes and use css to show/hide it?

I believe it is imported from a page performance optimization, committed by @lei9444 , trying to decrease design page second open time , it cost about 2 ~ 3 seconds at first time render visual&form editor @a-b-r-o-w-n

@cwhitten cwhitten merged commit cde21e2 into microsoft:master Dec 7, 2019
@zhixzhan zhixzhan deleted the bugfix branch December 9, 2019 02:00
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants