fix: location select Content component #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweitian
requested review from
a-b-r-o-w-n,
boydc2014,
cwhitten,
luhan2017 and
yeze322
as code owners
liweitian
changed the title
liweitian
changed the title
compulim
reviewed
Nov 28, 2019
Composer/packages/client/src/CreationFlow/DefineConversation/index.js
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/CreationFlow/DefineConversation/index.js
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/CreationFlow/DefineConversation/index.js
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/CreationFlow/DefineConversation/index.js
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/CreationFlow/DefineConversation/index.js
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/CreationFlow/DefineConversation/index.js
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/CreationFlow/DefineConversation/index.js
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/CreationFlow/DefineConversation/index.js
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
requested changes
Dec 2, 2019
Composer/packages/client/src/CreationFlow/DefineConversation/index.js
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/CreationFlow/DefineConversation/index.js
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/CreationFlow/DefineConversation/index.js
Outdated
Show resolved
Hide resolved
| }) && | ||
| i < MAXTRYTIMES | ||
| ); | ||
| return defaultName; |
There was a problem hiding this comment.
So if MAXTRYTIMES is reached without finding a unique name, the default name will be the last computed name and invalid right?
There was a problem hiding this comment.
Previously, it will be an endless loop if we cannot find an unique name(probably due to a bug). According to @compulim, we should throw an error when the MAXTIMES reached. But I feel even if this do happen, we should not decrease user's experience. This is a small feature. So I keep the code this way just like what you said. If the code generate a duplicated name, an error message will show.
Composer/packages/client/src/CreationFlow/LocationBrowser/LocationSelectContent.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/CreationFlow/LocationBrowser/LocationSelectContent.tsx
Show resolved
Hide resolved
| if (storages && storages.length > 0) { | ||
| const storageId = storages[currentStorageIndex.current].id; | ||
| const path = storages[currentStorageIndex.current].path; | ||
| const formatedPath = Path.normalize(path); |
There was a problem hiding this comment.
This was marked resolved, but was not addressed.
liweitian
changed the title
liweitian
force-pushed
the
liweitian/refactor
branch
from
754dce4
to
37cc1da
Compare
liweitian
changed the title
cwhitten
changed the title
cwhitten
approved these changes
Dec 5, 2019
This was referenced Dec 5, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the locationSelectContent part to make it more pure.
The overall idea/code flow becomes. Every time we changed the location(the last accessed path), it will save to data.json, then the storages in stores(global state) will be changed too. This will trigger updating the focuedStorageFolder.
Task Item
closes #1603
closes #1291
Type of change
Please delete options that are not relevant.
Checklist
Screenshots