[WIP] add expression parser to server dependencies

[a-b-r-o-w-n]

@hailiu2586 identified a few other packages that need to be added:

• botbuilder-lg
• ludown
• lubuild

[boydc2014]

@lei9444 can you help complete this, you know best about the exact version. this is abs related, for some reasons, yarn package resolution seems to not working. I think it's because the expression parser is published in myget. anyway, let's add them for now.

[boydc2014]

em ... this is weird , lubuild is already there, in server/package.json and server never used botbuilder-lg nor botbuilder-expression-parser nor ludown, it's lib/indexers who depends on that. Not sure why those are identified those are missing packages. @hailiu2586 can you share the bundling process you used, so we can test and verify the fix? maybe create an issue with the description of expected behavior.

I suspect it might related to those packages are referred directly through url, instead of just version + config in npmrc. So @lei9444 you can create a PR which totally remove the use of absolute url in favor of the config in npmrc. We probably should rename all those with a @bfcomposer prefix.

I think that would largely fix the issue and keep us clean, at the same time Leilei you can talk to Hai about this if any special treatment need to be done here.

[boydc2014]

em ... this is weird , lubuild is already there, in server/package.json and server never used botbuilder-lg nor botbuilder-expression-parser nor ludown, it's lib/indexers who depends on that. Not sure why those are identified those are missing packages. @hailiu2586 can you share the bundling process you used, so we can test and verify the fix? maybe create an issue with the description of expected behavior.

I suspect it might related to those packages are referred directly through url, instead of just version + config in npmrc. So @lei9444 you can create a PR which totally remove the use of absolute url in favor of the config in npmrc. We probably should rename all those with a @bfcomposer prefix.

I think that would largely fix the issue and keep us clean, at the same time Leilei you can talk to Hai about this if any special treatment need to be done here.

I think i understand the problem, actually it's the same problem of our docker build.

• We want a bundled server or at least minimal server after we bundled client.
  We support that previously, but that's broken after we make server depends on "lib/shared" and "lib/indexers".

Before that, our server can install fully self-contained, in the docker build, i even created a clean layer for server to run yarn install separately.

# use a multi-stage build to reduce the final image size
FROM node:10-alpine
WORKDIR /app/Composer/server
COPY --from=build /src/Composer/packages/server .
RUN yarn --production && yarn cache clean

So, the packages Hai identified are the dependencies of 'lib/shared' and 'lib/indexers', perhaps @hailiu2586 already copied those two packages it self directly into server.

Anyway, we should fix this by give server a way to properly bundle itself, or at least bring the dependencies into server folder easily.

So not related to absolute url, it's a bundle issue we need to solve for abs-h and for our docker.

[boydc2014]

I guess this is no longer needed? as long as abs-h followed the steps in our Dockerfile?

[a-b-r-o-w-n]

You are correct.

…

________________________________ From: Dong Lei <notifications@github.com> Sent: Friday, November 1, 2019 6:16:28 PM To: microsoft/BotFramework-Composer <BotFramework-Composer@noreply.github.com> Cc: Andy Brown <Andy.Brown@microsoft.com>; Author <author@noreply.github.com> Subject: [EXTERNAL] Re: [microsoft/BotFramework-Composer] [WIP] add expression parser to server dependencies (#1440) I guess this is no longer needed? as long as abs-h followed the steps in our Dockerfile? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FBotFramework-Composer%2Fpull%2F1440%3Femail_source%3Dnotifications%26email_token%3DAA3TR5CHJNAVDWFEZXHGHLTQRTIGZA5CNFSM4JHTX4XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4QKZQ%23issuecomment-548996454&data=02%7C01%7Candy.brown%40microsoft.com%7Cfddc18c14c2f4e13309908d75f324a5a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637082541927534581&sdata=7dcVaXiYViE%2FDUKrnExUM9lG9knyGDesIhzzAJr4IUc%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA3TR5C3BY7SHZOMIHK5W5LQRTIGZANCNFSM4JHTX4XA&data=02%7C01%7Candy.brown%40microsoft.com%7Cfddc18c14c2f4e13309908d75f324a5a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637082541927544584&sdata=9coxCBSCrtHo3XwK1%2F6IufLj%2BXJrd3cCLLZY7VqaTMo%3D&reserved=0>.