Changes on bot files won't take effect by refreshing the design page

[yeze322]

Describe the bug

The behavior of 'open project' and 'get project' are different. 'open project' will always fetch the newest dialog data while 'get project' won't.

What I did here is editing a main.dialog file via a plain text editor, then tried 2 approaches to refetch the bot content (1. refresh the page 2. reopen the bot from Home page)

Found that

• 'get project' returns old data, hits cached data
  
• 'open' returns new data
  

Repro steps:

1. Update the bot content file under YOUT_BOT_PRJECT folder, for example, removing an action
2. go back to design page (content not updated)
3. refresh design page (content still not updated)
4. go to home page, open the bot by click the blue text under Recent Bots (schema updated)

Version

Browser

• Chrome
• Safari
• Firefox
• Edge

OS

• macOS
• Windows
• Ubuntu

To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior

Screenshots

Additional context

[yeze322]

@benbrown @VanyLaw could you help triaging this issue, I think it's related to some recent changes

[yeze322]

This issue affects the behavior of custom schema story as well, all file (.diaog/.schema) under the bot project won't be refreshed by refreshing the page.

After ejected a custom runtime with custom schema files, users have to 'reopen' a bot project to see what's changed in schema.

[VanyLaw]

@yeze322 Currently, after refreshing server will return cache project files instead of geting the bot from disk. Server will get bot from disk only when open/reopen a bot. And I am not sure is it a bug? because it's a normal way to save time. And I am not sure if it can refresh in electron
For the dialog update, it's better to change through dialog editor (click show code).
And I think the better way to handle this situation is add a editor for user to edit or add a button in frontend to support user upload new file. In a word, make composer aware the change.

However, if it's need to re-get bot files from disk every time we refresh, I can use the open_project api in here.

@benbrown what do you think?

[yeze322]

@VanyLaw I'm not quite with you about the motivation 'to save time'. If we really want to avoid reading disk files frequently, there is a HTTP status code 304 'Not Modified' to handle that.

Anyway, functionally we need to support one scenario here:

1. User switches to 'Settings' page
2. User enables an ejected(custom) runtime in which contains a custom sdk.schema
3. Then switches back to design page, the 'sdk.schema' needs to be up-to-date
   (it's not a natural flow to expect user can 'reopen' the bot proactively)

[VanyLaw]

I update the botproject in server cache after eject, that can return botproject include schema files when user refresh.

[yeze322]

Thanks @VanyLaw ! It can support the ejected scenario well