Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node, TypeScript, and Yeoman generator to sue 4.1.5 of the SDK #858

Merged
merged 15 commits into from
Nov 6, 2018
Merged

Update Node, TypeScript, and Yeoman generator to sue 4.1.5 of the SDK #858

merged 15 commits into from
Nov 6, 2018

Conversation

sgellock
Copy link
Member

@sgellock sgellock commented Nov 6, 2018

Fixes #857

Proposed Changes

  • Update nodejs samples to use 4.1.5 of the SDK
  • Update nodejs sample dependencies to their current versions
  • Delete all package-lock.json files
  • Add package-log.json to .gitignore
  • Update typescript samples to use 4.1.5 of the SDK
  • Update typescript sample dependencies to their current versions
  • Update Yeoman generated samples to use 4.1.5 of the SDK

sgellock added 15 commits October 24, 2018 15:47
@sgellock
Fix Readme Typos
fec376b
@sgellock
Merge branch 'master' of https://github.com/Microsoft/BotBuilder-Samples
c28664d 
 into sgellock/yeoman-4-1
@sgellock
update to 4.1 of the sdk
89cc584
@sgellock
Merge branch 'master' of https://github.com/Microsoft/BotBuilder-Samples
790791f 
 into sgellock/yeoman-4-1
@sgellock
put See aka.ms link on separate line
43abe6e 
increase code readability by putting See aka.ms links on their own line
@sgellock
Merge branch 'master' of https://github.com/Microsoft/BotBuilder-Samples
e2b2734 
 into sgellock/yeoman-4-1
@sgellock
put See aka.ms link on separate line
b9f3b9d 
increase code readability by putting See aka.ms links on their own line
@sgellock
Merge branch 'master' of https://github.com/Microsoft/BotBuilder-Samples
f226651 
 into sgellock/yeoman-4-1
@sgellock
Merge branch 'master' of https://github.com/Microsoft/BotBuilder-Samples
4c8c4d5 
 into sgellock/yeoman-4-1
@sgellock
Merge branch 'master' of https://github.com/Microsoft/BotBuilder-Samples
e972df2 
 into sgellock/yeoman-4-1
@sgellock
Merge branch 'master' of https://github.com/Microsoft/BotBuilder-Samples
610abd9 
 into sgellock/yeoman-4-1
@sgellock
Update node and typescript samples to v4.1.5 of the SDK
6dac263 
- remove package-lock.json
- add package-lock.json to gitignore
- update package.json to use 4.1.5 of the SDK
- update any other module dependencies to their current version
@sgellock
Merge branch 'master' of https://github.com/Microsoft/BotBuilder-Samples
137bf1f 
 into sgellock/yeoman-4-1
@sgellock
Update Yeoman templates to use v4.1.5 SDK
ae68702
@sgellock
Bump patch version number
47e746f
@sgellock sgellock self-assigned this Nov 6, 2018
vishwacsena
vishwacsena approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@vishwacsena vishwacsena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. How do we verify that all samples work E2E with 4.1.5? Is that being covered as a separate effort?

@sgellock sgellock merged commit 8878a1e into master Nov 6, 2018
@sgellock sgellock deleted the sgellock/yeoman-4-1 branch November 6, 2018 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwacsena vishwacsena vishwacsena approved these changes

@cleemullins cleemullins Awaiting requested review from cleemullins

Assignees

@sgellock sgellock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgellock @vishwacsena