Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node]Update node version to 16 in ARM templates #3921

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

JhontSouth
Copy link
Collaborator

@JhontSouth JhontSouth commented Oct 24, 2023

#minor

Description

This PR updates the default node version to 16 in the ARM templates of every sample that uses node.

Proposed Changes

  • Updated the default node version to ~16 in the template-BotApp-new-rg.json files which use node.

Testing

These images show the bot deployed with ARM templates working with node 16.
image
image

@JhontSouth JhontSouth requested a review from a team as a code owner October 24, 2023 20:20
@JhontSouth JhontSouth closed this Oct 24, 2023
@JhontSouth JhontSouth reopened this Oct 24, 2023
@tracyboehrer tracyboehrer merged commit 08f1c45 into main Oct 24, 2023
@tracyboehrer tracyboehrer deleted the southworks/update/templates-node-version branch October 24, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants