This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Zoma/test bot #3029
Merged
Zoma/test bot #3029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrimc62
reviewed
Jan 15, 2021
| .AddInMemoryCollection(new Dictionary<string, string> { { "root", root }, { "region", region }, { "environment", environment } }) | ||
| .UseMockLuisSettings(root, root) | ||
| .AddUserSecrets("RunBot") | ||
| .AddInMemoryCollection(new Dictionary<string, string> { { "root", root }, { "region", region }, { "environment", environment }, {"userSecrets", userSecrets} }) |
There was a problem hiding this comment.
"userSecrets", userSecrets} [](start = 145, length = 27)
I don't think you need this. The only place it is used is in the Mock Luis. #Resolved
chrimc62
reviewed
Jan 15, 2021
| script.push({ | ||
| $kind: 'Microsoft.Test.CustomEvent', | ||
| name: 'SetTestOptions', | ||
| value: `{randomValue : ${record.value.randomValue}}` |
There was a problem hiding this comment.
`{randomValue : ${record.value.randomValue} [](start = 23, length = 43)
Value should be the whole record.value. This will pick up randomValue/randomSeed and anything else added. #Resolved
chrimc62
reviewed
Jan 15, 2021
| } else if (isSettingRandomValue(record)) { | ||
| script.push({ | ||
| $kind: 'Microsoft.Test.CustomEvent', | ||
| name: 'SetTestOptions', |
There was a problem hiding this comment.
SetTestOptions [](start = 23, length = 14)
I like emitting the custom event since this uses the protocol and we know the underlying bot supports SetTestOptionsMiddleware to pick it up. #Resolved
chrimc62
reviewed
Jan 15, 2021
| return record.type === 'trace' && record.valueType === 'Microsoft.HttpRequest' | ||
| } | ||
|
|
||
| function isSettingRandomValue(record: any): Boolean { |
|
The only change I would make is to copy the whole event value into the script. #Resolved |
coldplaying42
requested review from
a team,
GeoffCoxMSFT and
boydc2014
as code owners
This was referenced Jan 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3022
Proposed Changes
Testing