[JS sample] Add CoreBot with Application-Insights #1773

gasper-az · 2019-09-13T15:34:50Z

Proposed Changes

Add sample 21.corebot-app-insights, based on JS Sample#13

More Information

This sample:

Uses LUIS to implement core AI capabilities
Implements a multi-turn conversation using Dialogs
Handles user interruptions for such things as Help or Cancel
Prompts for and validates requests for information from the user
Uses Application Insights to monitor your bot

Testing

To test this sample:

Clone this branch
In a terminal, navigate to samples/javascript_nodejs/21.corebot-app-insights
Install modules with npm install
Setup LUIS
Run the sample with npm start

Add DialogBot Add DialogAndWelcomeBot Add Resources for DialogAndWelcomeBot

Add BookingDialog Add cancelAndHelpDialog Add dateResolverDialog

Add Index.js Add cognitivesModels folder Add deploymentTemplates folder Fix minor issues in dialog & dialogBot

samples/javascript_nodejs/21.corebot-app-insights/README.md

samples/javascript_nodejs/21.corebot-app-insights/package.json

* Replace appsettings.json with .env file. * Add information about appInsights instrumentation key.

samples/javascript_nodejs/21.corebot-app-insights/index.js

Add bookingDialog as a parameter of mainDialog instead of creating it.

samples/javascript_nodejs/21.corebot-app-insights/index.js

samples/javascript_nodejs/21.corebot-app-insights/bots/resources/welcomeCard.json

samples/javascript_nodejs/21.corebot-app-insights/README.md

daveta

Nice - thanks Gaspar!

- index.js: uncommented line for using restify.plugins.bodyParser. - welcomeCard.json: set isSubtle to true. - README.md: replace references to sample 13 with references to Sample 21. - README.md: add link to AppInsights documentation.

daveta

Nice - thanks!!

- As the mainDialog extends ComponentDialog, it s not necessary to pass the TelemetryClient as a parameter in its constructor. Instead, we can use the telemetryClient property from the ComponentDialog.

WashingtonKayaker

Please make these changes to revert this code back to what it is in the coreBot sample app. The purposes of this sample app is very narrowly focused to show only what changes are required to update the coreBot sample app to add telemetry capabilities. Any changes beyond that will detract from that purpose.

I also noticed the string interpolation changes you made as well, and I think those are OK (in my opinion they are better, and virtually unnoticeable and I can get away with not documenting them)

samples/javascript_nodejs/21.corebot-app-insights/dialogs/bookingDialog.js

samples/javascript_nodejs/21.corebot-app-insights/index.js

WashingtonKayaker

Please revert all non-critical changes not required to implement telemetry.

samples/javascript_nodejs/21.corebot-app-insights/dialogs/mainDialog.js

WashingtonKayaker

Please remove brackets, unless there is an important reason to change, please revert these changes.

samples/javascript_nodejs/21.corebot-app-insights/dialogs/cancelAndHelpDialog.js

- Restore MainDialog previous constructor. - Restore Booking Dialog previous contructor. - Removed unnecessary brackets.

garypretty · 2020-01-23T12:51:18Z

I will re-open this PR shortly once I have made updates to the sample to use latest telemetry pieces

gasper-az and others added 27 commits September 11, 2019 11:41

[AppInsights Sample] Init project [WIP]

f5643db

add ErrorViewModel class

b6196bc

add cancel dialog

271e30e

add dateResolver dialog

24b9952

Change ! to cast as boolean

3ca77fd

[AppInsights sample] Add dialogBot

93db436

[AppInsights sample] Export DialogBot

878adf6

[AppInsights Sample] create DialogState

ceae8a3

[AppInsight sample] dialogAndWelcomeBot + resource

0c1e07a

[AppInsight Bot] Fix styling.

935ac9e

add header

1fec03a

[AppInsights-Bot] Add ErrorViewModel class

fbb6d0f

[AppInsights Bot] Add Bot folder

f8186d2

Add DialogBot Add DialogAndWelcomeBot Add Resources for DialogAndWelcomeBot

add bookingDialog

29c9817

[AppInsights Bot] Add new Dialogs

7e1f808

Add BookingDialog Add cancelAndHelpDialog Add dateResolverDialog

[AppInsights Bot] Add mainDialog [WIP]

7d9b209

[AppInsights Bot] Add mainDialog

0e74c2d

[AppInsights Bot] Add MainDialog

531c5f9

[AppInsights Bot] Add index.js and flightBookingRecognizer

c323c54

[AppInsight Bot] fix minor issues in dialogs

4ca9ba8

[AppInsight Bot] Fix minor issues in dialogBot

b4d72c4

[AppInsights] add index.js

d457060

[AppInsights Bot] Add cognitiveModels

d54100c

Add deployment templates

e41954c

[ApiInsights Bot] Add index.js and folders

bbce2c9

Add Index.js Add cognitivesModels folder Add deploymentTemplates folder Fix minor issues in dialog & dialogBot

[AppInsights Bot] Add README.md file

84e5a60

Sample#21 - fix typo in mainDialog.js

793941d

scheyal reviewed Sep 13, 2019

View reviewed changes

samples/javascript_nodejs/21.corebot-app-insights/README.md Outdated Show resolved Hide resolved

scheyal reviewed Sep 13, 2019

View reviewed changes

samples/javascript_nodejs/21.corebot-app-insights/package.json Outdated Show resolved Hide resolved

Update README.md file

409d5ef

* Replace appsettings.json with .env file. * Add information about appInsights instrumentation key.

Fix ESLint Errors

5ba2e86

munozemilio suggested changes Sep 14, 2019

View reviewed changes

samples/javascript_nodejs/21.corebot-app-insights/index.js Outdated Show resolved Hide resolved

bookingDialog as parameter

3e6ce6a

Add bookingDialog as a parameter of mainDialog instead of creating it.

daveta reviewed Sep 16, 2019

View reviewed changes

samples/javascript_nodejs/21.corebot-app-insights/index.js Outdated Show resolved Hide resolved

daveta reviewed Sep 16, 2019

View reviewed changes

samples/javascript_nodejs/21.corebot-app-insights/bots/resources/welcomeCard.json Outdated Show resolved Hide resolved

daveta reviewed Sep 16, 2019

View reviewed changes

samples/javascript_nodejs/21.corebot-app-insights/README.md Outdated Show resolved Hide resolved

daveta reviewed Sep 16, 2019

View reviewed changes

samples/javascript_nodejs/21.corebot-app-insights/README.md Show resolved Hide resolved

daveta suggested changes Sep 16, 2019

View reviewed changes

Apply feedback on Sample 21

b0d8ffe

- index.js: uncommented line for using restify.plugins.bodyParser. - welcomeCard.json: set isSubtle to true. - README.md: replace references to sample 13 with references to Sample 21. - README.md: add link to AppInsights documentation.

daveta approved these changes Sep 17, 2019

View reviewed changes

munozemilio approved these changes Sep 18, 2019

View reviewed changes

Sample21: Use TelemetryClient through ComponentDialog

055c3d7

- As the mainDialog extends ComponentDialog, it s not necessary to pass the TelemetryClient as a parameter in its constructor. Instead, we can use the telemetryClient property from the ComponentDialog.

WashingtonKayaker reviewed Sep 30, 2019

View reviewed changes

samples/javascript_nodejs/21.corebot-app-insights/dialogs/bookingDialog.js Show resolved Hide resolved

samples/javascript_nodejs/21.corebot-app-insights/index.js Show resolved Hide resolved

samples/javascript_nodejs/21.corebot-app-insights/index.js Show resolved Hide resolved

WashingtonKayaker reviewed Sep 30, 2019

View reviewed changes

WashingtonKayaker reviewed Oct 1, 2019

View reviewed changes

Sample 21: Restored previous Dialog constructors.

2e215cd

- Restore MainDialog previous constructor. - Restore Booking Dialog previous contructor. - Removed unnecessary brackets.

WashingtonKayaker approved these changes Nov 22, 2019

View reviewed changes

johnataylor closed this Jan 23, 2020

Merge branch 'master' into feature/corebot-app-insights

9364032

garypretty reopened this Jan 23, 2020

garypretty merged commit 5b86f09 into master Jan 23, 2020

garypretty mentioned this pull request Jan 23, 2020

Update and align App Insights CoreBot samples across all languages #2012

Closed

snyk-bot mentioned this pull request May 11, 2021

[Snyk] Fix for 1 vulnerabilities wasimakh2/BotBuilder-Samples#20

Open

snyk-bot mentioned this pull request Sep 3, 2021

[Snyk] Fix for 1 vulnerabilities wasimakh2/BotBuilder-Samples#23

Open

tracyboehrer deleted the feature/corebot-app-insights branch July 8, 2022 16:57

[JS sample] Add CoreBot with Application-Insights #1773

[JS sample] Add CoreBot with Application-Insights #1773

Uh oh!

Conversation

gasper-az commented Sep 13, 2019

Proposed Changes

More Information

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daveta left a comment

Choose a reason for hiding this comment

Uh oh!

daveta left a comment

Choose a reason for hiding this comment

Uh oh!

WashingtonKayaker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WashingtonKayaker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WashingtonKayaker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

garypretty commented Jan 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants