This repository was archived by the owner on Jan 5, 2026. It is now read-only.
4.5.1 Corebot updates #1570
Merged
4.5.1 Corebot updates #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated messages and prompts so they work with speech.
…consistent across the board.
* Added UnitTests for CoreBot * Added readme file * Testing images in readme * WIP updated Readme. * Updated readme * Added Analyzing Test Output section to redame * Added link to xunit docs * Added Theory tests with InlineData section * Fixed some typos * allow latest C# features * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates * readme updates
Update AdapterWithErrorHandler to use IConfiguration Update csproj to use 4.4.5 bot fx Remove ICredentialProvider from startup.cs
update AdapterWithErrorHandler to use new constructor update cs proj to 4.4.5 version of bot fx remove ICredentialProvider from statup.cs remove ConfigurationCredentialProvider.cs
Remove CreateReply (use MessageFactory)
Remove ConfigurationCredentialProvider and DialogExtensions from CoreBot
…ues caused by breaking changes.
* Initial readme cloned from dotnet * Readme updates * Readme updates. Moved images to a new folder. * Updated corebot JS to the new version with unit tests. Updated comments and some names in the C# version for parity with JS.
Shortened the readme and added link to docs.microsoft.com
Fixed some typos.
Added channel ID
Removed await from getNextReply
gabog
reviewed
Jul 15, 2019
…lder-Samples into corebot-updates
…vidual apsnet core packages to avoid conflicts when changing TargetFramework.
- restructure folder to enable CoreBot and CoreBot.Tests - update CoreBot to use latest structure - update to use 4.5 of Bot Framework - update README.md to document how to use —include-tests command line option and the fact that generating CoreBot.Tests is a new capability of the template - minor bug fixes - bump version numbers to 4.5.0
…lder-Samples into corebot-updates
replace placeholder link to use correct aka.ms link
update template code to match final version
- removed old commented out markup
…lder-Samples into corebot-updates
* V3 state bot, and v4 state bot that uses Bot.Builder.Azure.V3ToV4 for UserState (#1573) * add v3 state bot, and v4 state bot that uses Bot.Builder.Azure.V3ToV4 to connect to v3 stored UserState * add/update migration readmes. Add AzureSql-CreateTable.sql remove secret from V3StateBot default.htm * [Expression_Document]Add doc for built-in functions (#1592) * Update the usage of TemplateEngine Update the usage of TemplateEngine. Currently, template engine will use new TemplateEngine().AddFiles() to load lg files * update usage doc of some date time functions * add some description for expression functions * Add some function description and examples * Add description & examples for built-in functions * Add examples and descriptions * add some conversion functions * fix some format and add some uri conversion func * Add missiong docs for built-in functions * delete fromFile in LG readme doc * Add parameters.json for ARM templates (#1627) * add initial ARM template parameters.json * cleanup ARM template parameters.json * add parameters.json files to all samples * add ARM parameter.json files to generators * update ts corebot sample, port tests * fix tslint errors, add tslint rules * apply init PR feedback to TS core-bot * apply @gabog's feedback to TS core-bot * remove redundant state save from TS core-bot
…he replace call and avoid creating infinite nested parents.
Updated tests to pass.
stevengum
approved these changes
Jul 17, 2019
stevengum
changed the title
…lder-Samples into corebot-updates # Conflicts: # experimental/common-expression-language/prebuilt-functions.md
- corebot updates - prompting for test project, but to be implemented
- use latest lint rules in prep for moving off of tslint - fix lint rule violations - fix broken aka.ms links with new working aka.ms link
…lder-Samples into corebot-updates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been reported that people expect in Core bot the book details to contain the city if it matches the ML composite but misses the closed list.
This isn't exactly correct, the response from LUIS can be a little confusing when the composite matches but the entity doesn't; clearly the model is stating a closed set of airports, the intention is that a city not in this list is not somewhere you can fly to or from. The good news is that this case can be identified in the LUIS response. Specifically the child of the composite is empty but the entity is there. The correct behavior in the bot is therefore to spot this as an error and send that fact to the user.
The fact that later inline recognizers don't honor the closed nature of the list is really also a bug but we've left that as an exercise for the application developer. We could add a comment to include a PromptValidator; however the real underlying problem is that the model is split between code and the LUIS model.