DLS Client Error when connecting experimental Core Bot to Azure

[splumber]

Github issues for C#

Experimental CoreBot

Environment

C# .NET Core

Sample information

1. Sample type: /experimental/directline-speech/csharp_dotnetcore/13.core-bot/
2. Sample language: dotnetcore
3. Sample name: 13.core-bot

Describe the bug

The steps followed to deploy this bot can be found in the following link

Experimental Core Bot Sample throws an error in Direct Line Speech Client after deploying to Azure.

This error is only encountered when the Core Bot is deployed to Azure and is tested using the DLS Client.
Running and testing the Core Bot locally using the Bot Emulator does not result in a error.

In order to resolve the issue

1. Navigate to CoreBot/Cards/welcomeCard.json -> on Line 23, change isSubtle from 'yes' to true.
2. Redeploy Bot and reconnect DLS Client using DLS Secret Key and Cognitive Services Speech API key.
3. Error should be resolved.

To Reproduce

Steps to reproduce the behavior:

1. Go to 'CoreBot/Cards/welcomeCard.json'
2. If 'isSubtle' is true, change it to 'yes'
3. Reconnect DLS Client
4. Error shown in DLS Client

Expected behavior

Upon DLS connection to CoreBot, an Adaptive Card is expected to be displayed.
Due to the parsing error in either the Bot or the DLS Client, an error is thrown on connection.
Once the isSubtle in welcomeCard.json field is changed, the error is resolved and the Adaptive Card is displayed.

Screenshots

Error Field

Fixed Error Field

Additional context

This is the link to the Adaptive Cards API
isSubtle must be a Boolean, although it is not a required field, an incorrect value causes an error in the deployed version (no error in the locally run version)

Additional Issues are related to the Bot Emulator and Bot Channels Registration Web Chat.
The deployed bot does not run in the Bot Emulator or the Web Chat.
https://[botname].azurewebsites.net/api/messages
returns a http 500 error in the Emulator

[bug]

[tsuwandy]

@CoHealer , who could take a look at this one? thank you!

[tsuwandy]

@dargilco, could you take a look?

[DDEfromOR]

BotBuilder-Samples/samples/csharp_dotnetcore/13.core-bot/Cards/welcomeCard.json

Line 23 in 61f9ad2

"isSubtle": "yes",

It looks like the value has always been set to "yes", but this may be the first time we've had a non-JS client trying to parse it. Potential solutions:

1. Update the sample to have a valid boolean value, like @splumber has shown, or
2. Update the DLS client to interpret "yes" as truthy in the same way a JS client would.

I'd recommend 1 unless there is some reason for this value being set to "yes" that isn't clear here.

[dargilco]

Agree with Daniel. If it's a boolean field, let's change it to "true". Otherwise anyone writing a C# client application to communicate with Core Bot will see this bug.

[tsuwandy]

Fixed for all samples in repo. Thanks!