Skip to content

[Payables Agent] Enhance historical data loading with error handling and telemetry #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+29 −3
Open

[Payables Agent] Enhance historical data loading with error handling and telemetry #5106

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22acb39
Enhance historical data loading with error handling and telemetry log…
dayland-ms Oct 8, 2025
7e3912b
Add locking to historical data load error label for consistency
dayland-ms Oct 10, 2025
9ad809a
Refactor error logging in historical data loading to include call sta…
dayland-ms Oct 10, 2025
b94e205
Refactor historical data loading remove redundant function
dayland-ms Oct 10, 2025
b384847
Remove unused TelemetryDimensions variable from LoadHistoricalDataInt…
dayland-ms Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions src/Apps/W1/EDocument/App/src/Processing/AI/Tools/EDocHistoricalMatching.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ codeunit 6177 "E-Doc. Historical Matching" implements "AOAI Function", IEDocAISy
TempHistoricalMatchBuffer: Record "EDoc Historical Match Buffer" temporary;
EDocSimilarDescriptions: Codeunit "E-Doc. Similar Descriptions";
EDocumentNo: Integer;
HistoricalDataLoadFailedErr: Label 'Failed to load historical data for e-document %1. Error: %2', Comment = '%1 = E-Document System Id, %2 = Error message', Locked = true;
AIHistoricalDataLoadEventTok: Label 'Historical Data Load', Locked = true;

trigger OnRun()
var
Expand Down Expand Up @@ -81,11 +83,16 @@ codeunit 6177 "E-Doc. Historical Matching" implements "AOAI Function", IEDocAISy
EDocumentPurchaseHeader: Record "E-Document Purchase Header";
EDocHistoricalMatchingSetup: Record "EDoc Historical Matching Setup";
TempPurchInvLine: Record "Purch. Inv. Line" temporary;
FeatureTelemetry: Codeunit "Feature Telemetry";
VendorNo: Code[20];
EDocSystemId: Guid;
ErrorMessage: Text;
begin
if not EDocumentPurchaseLine.FindFirst() then
exit(false);

EDocSystemId := EDocumentPurchaseLine.SystemId;

// Get vendor from header
EDocumentPurchaseHeader.SetRange("E-Document Entry No.", EDocumentPurchaseLine."E-Document Entry No.");
if not EDocumentPurchaseHeader.FindFirst() then
Expand All @@ -100,8 +107,13 @@ codeunit 6177 "E-Doc. Historical Matching" implements "AOAI Function", IEDocAISy
if not EDocumentPurchaseLine.FindSet() then
exit(false);

// Load historical data
LoadHistoricalDataIntoTempTable(TempPurchInvLine, VendorNo, EDocHistoricalMatchingSetup);
// Load historical data with error handling
if not LoadHistoricalDataIntoTempTable(TempPurchInvLine, VendorNo, EDocHistoricalMatchingSetup) then begin
ErrorMessage := GetLastErrorText();
FeatureTelemetry.LogError('0000PUQ', GetFeatureName(), AIHistoricalDataLoadEventTok, StrSubstNo(HistoricalDataLoadFailedErr, EDocSystemId, ErrorMessage), GetLastErrorCallStack());
exit(false);
end;

if TempPurchInvLine.IsEmpty() then
exit(false);

Expand All @@ -112,13 +124,19 @@ codeunit 6177 "E-Doc. Historical Matching" implements "AOAI Function", IEDocAISy
exit(not TempHistoricalMatchBuffer.IsEmpty());
end;

[TryFunction]
local procedure LoadHistoricalDataIntoTempTable(var TempPurchInvLine: Record "Purch. Inv. Line" temporary; VendorNo: Code[20]; EDocHistoricalMatchingSetup: Record "EDoc Historical Matching Setup")
var
PurchInvLine: Record "Purch. Inv. Line";
FeatureTelemetry: Codeunit "Feature Telemetry";
OneYearAgoDate: Date;
RecordCount: Integer;
MaxHistoricalRecords: Integer;
StartTime: DateTime;
ElapsedTime: Duration;
TelemetryDimensions: Dictionary of [Text, Text];
begin
StartTime := CurrentDateTime();
OneYearAgoDate := CalcDate('<-1Y>', Today);
MaxHistoricalRecords := 5000; // Limit historical data to prevent performance issues

Expand All @@ -139,6 +157,14 @@ codeunit 6177 "E-Doc. Historical Matching" implements "AOAI Function", IEDocAISy
RecordCount += 1;
until (PurchInvLine.Next() = 0) or (RecordCount >= MaxHistoricalRecords);
end;

ElapsedTime := CurrentDateTime() - StartTime;
TelemetryDimensions.Add('Records loaded', Format(RecordCount));
TelemetryDimensions.Add('Duration (ms)', Format(ElapsedTime));
TelemetryDimensions.Add('Vendor matching scope', Format(EDocHistoricalMatchingSetup."Vendor Matching Scope"));
TelemetryDimensions.Add('Max records limit', Format(MaxHistoricalRecords));
TelemetryDimensions.Add('Limit reached', Format(RecordCount >= MaxHistoricalRecords));
FeatureTelemetry.LogUsage('0000PUR', GetFeatureName(), AIHistoricalDataLoadEventTok, TelemetryDimensions);
end;

local procedure CollectPotentialMatches(var EDocumentPurchaseLine: Record "E-Document Purchase Line"; var TempPurchInvLine: Record "Purch. Inv. Line" temporary; EDocHistoricalMatchingSetup: Record "EDoc Historical Matching Setup"; VendorNo: Code[20])
Expand Down Expand Up @@ -359,7 +385,7 @@ codeunit 6177 "E-Doc. Historical Matching" implements "AOAI Function", IEDocAISy
UserMessage.Add('historicalMatches', HistoricalMatchesJson);
UserMessage.Add('matchingSetup', MatchingSetup);
UserMessage.WriteTo(UserMessageTxt);

OnUserMessageCreated(UserMessageTxt);
exit(UserMessageTxt);
end;
Expand Down
Loading