Changing 2 functions from internal to global

[AydinKelky]

Summary

Changing the following functions from internal to global

1. InitFromServiceCommitment in 8001 "Sub. Contract Renewal Line"
2. CreateCustomerContractLinesFromServiceCommitments in table 8052 "Customer Subscription Contract"

from internal to global

Work Item(s)

Fixes #

[AydinKelky]

@JesperSchulz Hi, I deleted my old repository and creared a new one based of 27.x as you suggested. Thank you for your help again

[github-actions]

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

[JesperSchulz]

@AydinKelky, I'm a little confused. Maybe let's start with the basics of how the process here on GitHub works 🙂

1. You create an issue, describing the change you want to make. The product group now takes a look at your issue and assess is that is something we can allow or not. -> I cannot seem to find that issue - did you create one?
2. With the approved issue, you are ready to create a PR against the main branch, to ensure your changes will release with upcoming versions of Business Central. -> you have closed your main PR without merging it, so now your changes won't be part of the coming major release or any subsequent releases!
3. If you now would like to release your changes in the upcoming minor release, because you cannot wait for the next major, you can cherry-pick the changes from the main branch and into the releases/2X.X branch. -> this seems to be this PR?

Let's get things sorted out and then get this into the product. Unless I missed something or misunderstood something, here's my suggestion:

1. Create an issue and I'll approve it right away
2. Reopen your main PR (Changing 2 function from internal to global #4863) and let's get that merged. Consider the review feedback you also received here
3. One changes are merge into main, let's process this PR.

[AydinKelky]

@JesperSchulz maybe it was a misunderstanding from my part which I tought I should close the previous PR and make a new one.

1. I forgot to create an issue and went straight to the PR. Sorry. Should I create an issue?
2. It was my mistake, when I asked you if it was possible to move the changes to minor release, based on your answer, I tought, I needed to create a new PR based on the minor release branch and close the old one.
3. You're right. That was my intention.

UnfortunateI cant reopen tthe old PR since I deleted my old fork. I made a new one
#5090

[JesperSchulz]

Ok, let's do this 🙂

[JesperSchulz]

Processing #5090 first.