-
Notifications
You must be signed in to change notification settings - Fork 257
backport fornav edoc connector #4865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: releases/27.x
Are you sure you want to change the base?
backport fornav edoc connector #4865
Conversation
Hi @renebrummel. Just FYI, i had to fix some issues in the fornav test code, that broke when i tried to uptake the BCapps version with it. So just be sure to sync those changes in. |
@Groenbech96 Got it, I just merged them in from main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still not quite the right version numbers. All version numbers should say "27.1.0.0" except the platform ones. Those should say "27.0.0.0". Same way the Avalara app.json is: https://github.com/microsoft/BCApps/blob/releases/27.x/src/Apps/W1/EDocumentConnectors/Avalara/App/app.json
I added a comment all the places that need to be updated. If you apply those changes it should be all good 👍
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Summary
Backport FORNAV edocumentconnector to 27.1
Work Item(s)
Fixes AB#572834