Skip to content

Conversation

renebrummel
Copy link
Contributor

@renebrummel renebrummel commented Sep 24, 2025

Summary

Backport FORNAV edocumentconnector to 27.1

Work Item(s)

Fixes AB#572834

@renebrummel renebrummel requested review from a team as code owners September 24, 2025 08:41
@github-actions github-actions bot added From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item labels Sep 24, 2025
@github-actions github-actions bot added this to the Version 27.1 milestone Sep 24, 2025
@Groenbech96
Copy link
Contributor

Hi @renebrummel.

Just FYI, i had to fix some issues in the fornav test code, that broke when i tried to uptake the BCapps version with it.
As you can see i have merged 2 prs.

So just be sure to sync those changes in.

@renebrummel
Copy link
Contributor Author

renebrummel commented Sep 24, 2025

Hi @renebrummel.

Just FYI, i had to fix some issues in the fornav test code, that broke when i tried to uptake the BCapps version with it. As you can see i have merged 2 prs.

So just be sure to sync those changes in.

@Groenbech96 Got it, I just merged them in from main

Groenbech96
Groenbech96 previously approved these changes Sep 24, 2025
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Sep 26, 2025
Copy link
Contributor

@aholstrup1 aholstrup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still not quite the right version numbers. All version numbers should say "27.1.0.0" except the platform ones. Those should say "27.0.0.0". Same way the Avalara app.json is: https://github.com/microsoft/BCApps/blob/releases/27.x/src/Apps/W1/EDocumentConnectors/Avalara/App/app.json

I added a comment all the places that need to be updated. If you apply those changes it should be all good 👍

renebrummel and others added 10 commits September 26, 2025 15:10
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
@Groenbech96 Groenbech96 enabled auto-merge (squash) October 1, 2025 07:21
Groenbech96
Groenbech96 previously approved these changes Oct 1, 2025
Copy link
Contributor

@Groenbech96 Groenbech96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Groenbech96 Groenbech96 disabled auto-merge October 1, 2025 07:24
@Groenbech96 Groenbech96 added the Approved The issue is approved label Oct 6, 2025
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Co-authored-by: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved The issue is approved From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants