Repository navigation
Move result types and judge selection onto category definitions - #935
Draft
Sun Haoran (haoranpb) wants to merge 1 commit into
Draft
Sun Haoran (haoranpb) wants to merge 1 commit into
Sun Haoran (haoranpb) wants to merge 1 commit into
Conversation
Sun Haoran (haoranpb)
added this pull request to stack #960
October 8, 2026 12:17
Contributor
Code Coverage OverviewLanguages: Python Python / code-coverage/pytestThe overall line coverage in commit 39b631a in the Show a line coverage summary of the most impacted files.
Updated |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| def make_pipeline(self) -> EvaluationPipeline[E]: | ||
| return self.pipeline_type() | ||
|
|
||
| def judge_model(self, judges: JudgeConfig) -> str | None: |
Definitions now declare their summary and aggregate types and their judge; pipelines declare the result type they produce. Category-aware loading and aggregation lives in bcbench.categories.results, so bcbench.results no longer looks up categories, and EvaluationContext carries the judge model explicitly. EvaluationCategory is now only the list of category names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sun Haoran (haoranpb)
force-pushed
the
app/stack-04-category-results
branch
from
October 8, 2026 13:13
fb6f5b6 to
39b631a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal 2, step 4. Stacked on #934.
CategoryDefinitiongainspipeline_type,summary_type,aggregate_typeandjudge. Each pipeline declares itsresult_type.bcbench.categories.results(load_result,summarize_results,aggregate_runs,load_summary,load_aggregate,load_leaderboard) replaces the base-classfrom_json/dispatch methods, sobcbench.resultsno longer looks up categories.EvaluationContext.judge_modelis set by the CLI fromJudgeConfig. The repair for timeouts recorded without a judge model (Handle judge-scored evaluation timeouts #822) moved intoload_result.EvaluationCategoryis now just the list of category names.