Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VM size configuration for Sonatype Nexus #4210

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Dec 18, 2024

Fixes #4209

Add VM size configurability for Sonatype Nexus VM.

  • Add a new parameter "vm_size" in templates/shared_services/sonatype-nexus-vm/parameters.json and templates/shared_services/sonatype-nexus-vm/porter.yaml.
  • Update templates/shared_services/sonatype-nexus-vm/template_schema.json to include an input field for "vm_size" with a dropdown list of recommended sizes.
  • Modify templates/shared_services/sonatype-nexus-vm/terraform/vm.tf to use the "vm_size" parameter instead of the hardcoded value.
  • Add a new variable "vm_size" in templates/shared_services/sonatype-nexus-vm/terraform/variables.tf with a default value of "Standard_B2ms".
  • Update the bundle version to "3.2.3" in templates/shared_services/sonatype-nexus-vm/porter.yaml.

For more details, open the Copilot Workspace session.

Copy link

github-actions bot commented Dec 18, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 04afaaf.

♻️ This comment has been updated with latest results.

@marrobi marrobi marked this pull request as draft December 18, 2024 16:41
@tamirkamara tamirkamara marked this pull request as ready for review December 24, 2024 16:35
marrobi and others added 2 commits December 24, 2024 16:39
Fixes #4209

Add VM size configurability for Sonatype Nexus VM.

* Add a new parameter "vm_size" in `templates/shared_services/sonatype-nexus-vm/parameters.json` and `templates/shared_services/sonatype-nexus-vm/porter.yaml`.
* Update `templates/shared_services/sonatype-nexus-vm/template_schema.json` to include an input field for "vm_size" with a dropdown list of recommended sizes.
* Modify `templates/shared_services/sonatype-nexus-vm/terraform/vm.tf` to use the "vm_size" parameter instead of the hardcoded value.
* Add a new variable "vm_size" in `templates/shared_services/sonatype-nexus-vm/terraform/variables.tf` with a default value of "Standard_B2ms".
* Update the bundle version to "3.2.3" in `templates/shared_services/sonatype-nexus-vm/porter.yaml`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4209?shareId=XXXX-XXXX-XXXX-XXXX).
@tamirkamara tamirkamara force-pushed the marrobi/add-vm-size-config branch from 591507e to 04afaaf Compare December 24, 2024 16:39
@tamirkamara tamirkamara requested a review from jonnyry December 24, 2024 16:45
@tamirkamara
Copy link
Collaborator

/test-forced-approve

Copy link

🤖 pr-bot 🤖

/test-forced-approve is not recognised as a valid command.

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator

/test-force-approve

Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 04afaaf)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) December 24, 2024 16:49
Copy link
Collaborator

@tim-p-allen tim-p-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Would be good to add some stuff to the docs about the vm sizes chosen.

@tamirkamara tamirkamara merged commit 2f57187 into main Dec 24, 2024
12 checks passed
@tamirkamara tamirkamara deleted the marrobi/add-vm-size-config branch December 24, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to choose size of Sonatype Nexus VM
3 participants