-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VM size configuration for Sonatype Nexus #4210
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 04afaaf. ♻️ This comment has been updated with latest results. |
Fixes #4209 Add VM size configurability for Sonatype Nexus VM. * Add a new parameter "vm_size" in `templates/shared_services/sonatype-nexus-vm/parameters.json` and `templates/shared_services/sonatype-nexus-vm/porter.yaml`. * Update `templates/shared_services/sonatype-nexus-vm/template_schema.json` to include an input field for "vm_size" with a dropdown list of recommended sizes. * Modify `templates/shared_services/sonatype-nexus-vm/terraform/vm.tf` to use the "vm_size" parameter instead of the hardcoded value. * Add a new variable "vm_size" in `templates/shared_services/sonatype-nexus-vm/terraform/variables.tf` with a default value of "Standard_B2ms". * Update the bundle version to "3.2.3" in `templates/shared_services/sonatype-nexus-vm/porter.yaml`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4209?shareId=XXXX-XXXX-XXXX-XXXX).
591507e
to
04afaaf
Compare
/test-forced-approve |
🤖 pr-bot 🤖
You can use the following commands: (in response to this comment from @tamirkamara) |
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 04afaaf) (in response to this comment from @tamirkamara) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would be good to add some stuff to the docs about the vm sizes chosen.
Fixes #4209
Add VM size configurability for Sonatype Nexus VM.
templates/shared_services/sonatype-nexus-vm/parameters.json
andtemplates/shared_services/sonatype-nexus-vm/porter.yaml
.templates/shared_services/sonatype-nexus-vm/template_schema.json
to include an input field for "vm_size" with a dropdown list of recommended sizes.templates/shared_services/sonatype-nexus-vm/terraform/vm.tf
to use the "vm_size" parameter instead of the hardcoded value.templates/shared_services/sonatype-nexus-vm/terraform/variables.tf
with a default value of "Standard_B2ms".templates/shared_services/sonatype-nexus-vm/porter.yaml
.For more details, open the Copilot Workspace session.