Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API ping endpoint #2778

Merged
merged 9 commits into from
Oct 24, 2022
Merged

Conversation

stuartleeks
Copy link
Contributor

Resolves #2777

What is being addressed

Describe the current behavior you are modifying. Please also remember to update any impacted documentation.

How is this addressed

  • Add richer error logging on healthcheck tests to aid any future diagnosis of healthcheck issues
  • Add simple ping endpoint (and make / an alias for this instead of the health check endpoint)
  • Update App Gateway health probe to /api/ping. Since the App Gateway probe was ignoring the content of the health check response, it is only testing that it can reach the API. The new ping endpoint will allow achieving this without incurring the cost of the Azure Management calls

@github-actions
Copy link

github-actions bot commented Oct 24, 2022

Unit Test Results

518 tests   518 ✔️  14s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 82fe1d5.

♻️ This comment has been updated with latest results.

Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely jubbly!

@stuartleeks
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3312904145 (with refid 6b54a360)

(in response to this comment from @stuartleeks)

@stuartleeks
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3313414546 (with refid 6b54a360)

(in response to this comment from @stuartleeks)

@stuartleeks
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3313772577 (with refid 6b54a360)

(in response to this comment from @stuartleeks)

@stuartleeks
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3314048374 (with refid 6b54a360)

(in response to this comment from @stuartleeks)

@stuartleeks stuartleeks enabled auto-merge (squash) October 24, 2022 15:47
@stuartleeks stuartleeks merged commit ae3efac into microsoft:main Oct 24, 2022
@stuartleeks stuartleeks deleted the sl/api-ping-endpoint branch October 24, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Processor Not OK
2 participants