Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new request functionality #2643

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Conversation

jjgriff93
Copy link
Collaborator

@jjgriff93 jjgriff93 commented Sep 23, 2022

Resolves #2354

What is being addressed

Implemented create airlock request functionality

How is this addressed

  • Created new routable component for new requests
  • Implemented steps for selecting request type and filling out associated details
  • Validation for request submission
  • API call and error handling

image

image

@github-actions
Copy link

github-actions bot commented Sep 23, 2022

Unit Test Results

0 tests   - 17   0 ✔️  - 16   0s ⏱️ -11s
0 suites  -   1   0 💤 ±  0 
0 files    -   1   0  -   1 

Results for commit bf8fe1e. ± Comparison against base commit e70790b.

♻️ This comment has been updated with latest results.

Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Few smaller things but happy for you to resolve/ignore/merge as you want

ui/app/src/components/shared/airlock/Airlock.tsx Outdated Show resolved Hide resolved
ui/app/src/components/shared/airlock/AirlockNewRequest.tsx Outdated Show resolved Hide resolved
ui/app/src/components/shared/airlock/AirlockNewRequest.tsx Outdated Show resolved Hide resolved
ui/app/src/components/shared/airlock/AirlockNewRequest.tsx Outdated Show resolved Hide resolved
@jjgriff93
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit bf8fe1e)

(in response to this comment from @jjgriff93)

@jjgriff93 jjgriff93 enabled auto-merge (squash) September 26, 2022 12:43
@jjgriff93 jjgriff93 merged commit 45c22cf into main Sep 26, 2022
@jjgriff93 jjgriff93 deleted the jjgriff93/2354_ui_airlock_new-requests branch September 26, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airlock UI: New Request
2 participants