Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AML when no users assigned a role, and upgrade Porter and TF mixin #2639

Merged
merged 7 commits into from
Sep 22, 2022

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Sep 22, 2022

Resolves #2549 and #2626

What is being addressed

  • Upgrade Porter to 0.38.13 in dev container and resource processor
  • Manually install latest Porter Terraform mixin in dev container
  • Do not assing AML roles if no users
  • Change log

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

Unit Test Results

0 tests   - 3   0 ✔️  - 2   0s ⏱️ - 1h 39m 6s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0  - 1 

Results for commit 670bebc. ± Comparison against base commit 6ae8b5e.

♻️ This comment has been updated with latest results.

@marrobi marrobi marked this pull request as draft September 22, 2022 20:16
@marrobi marrobi self-assigned this Sep 22, 2022
@marrobi marrobi marked this pull request as ready for review September 22, 2022 20:34
@marrobi
Copy link
Member Author

marrobi commented Sep 22, 2022

/test

@marrobi marrobi enabled auto-merge (squash) September 22, 2022 20:36
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3108570702 (with refid 4921364e)

(in response to this comment from @marrobi)

Copy link
Member

@martinpeck martinpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some comments

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@marrobi
Copy link
Member Author

marrobi commented Sep 22, 2022

/test-force-approve passed https://github.com/microsoft/AzureTRE/actions/runs/3108570702

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 670bebc)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit af8dbaa into microsoft:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AML Workspace service URL is incorrect
2 participants