Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyvault diagnostics in base workspace #2521

Merged
merged 3 commits into from
Aug 28, 2022
Merged

Keyvault diagnostics in base workspace #2521

merged 3 commits into from
Aug 28, 2022

Conversation

tamirkamara
Copy link
Collaborator

Resolves #2517

What is being addressed

Add diagnostics settings on the Keyvault in the base workspace.

@github-actions
Copy link

github-actions bot commented Aug 28, 2022 •
edited
Loading

Unit Test Results

0 tests   - 2   0 ✔️  - 1   0s ⏱️ - 59m 43s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0 ❌  - 1 

Results for commit 85ee46b. ± Comparison against base commit 84e2a33.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara force-pushed the tamirkamara/2517-kv-diag-base-workspace branch from e3ff059 to b9dd094 Compare August 28, 2022 08:18
@tamirkamara tamirkamara enabled auto-merge (squash) August 28, 2022 08:19
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2942307684 (with refid afe10eb2)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2942338011 (with refid afe10eb2)

(in response to this comment from @tamirkamara)

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2942338011 (with refid afe10eb2)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2943324514 (with refid afe10eb2)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara force-pushed the tamirkamara/2517-kv-diag-base-workspace branch from e73cf7b to 85ee46b Compare August 28, 2022 16:48
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2943792089 (with refid afe10eb2)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit d6c3dec into main Aug 28, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2517-kv-diag-base-workspace branch August 28, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybartal guybartal guybartal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Keyvault diagnostics in base workspace template
2 participants
@tamirkamara @guybartal