Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'ssl_cert_name' is a required property error #2435

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

stuartleeks
Copy link
Contributor

Resolves #2316

What is being addressed

Fix nexus install error on make all/make tre-deploy

How is this addressed

  • Add missing properties to nexus install target
  • Update .env.sample to set gitea/nexus to not install by default

@stuartleeks stuartleeks requested a review from marrobi August 10, 2022 05:40
@github-actions
Copy link

github-actions bot commented Aug 10, 2022

Unit Test Results

0 tests   - 5   0 ✔️  - 2   0s ⏱️ - 1h 22m 59s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0  - 3 

Results for commit c179449. ± Comparison against base commit c23f57a.

♻️ This comment has been updated with latest results.

@stuartleeks stuartleeks force-pushed the sl/2316-fix-nexus-makefile branch from 0523f66 to c179449 Compare August 10, 2022 08:08
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartleeks
Copy link
Contributor Author

/test-force-approve

nexus install not covered by PR tests

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit c179449)

(in response to this comment from @stuartleeks)

@stuartleeks stuartleeks merged commit f50640c into microsoft:main Aug 10, 2022
@stuartleeks stuartleeks deleted the sl/2316-fix-nexus-makefile branch August 10, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make tre-deploy: 'ssl_cert_name' is a required property Failed validating 'required' in schema:
2 participants