Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering to list Airlock requests #2433

Merged
merged 22 commits into from
Aug 15, 2022
Merged

Add filtering to list Airlock requests #2433

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
32bf4db
add query parameters to 'get all airlock requests' endpoint
yuvalyaron Aug 9, 2022
f879e8e
add allowed_user_actions to 'get all airlock requests' endpoint that …
yuvalyaron Aug 9, 2022
928985e
Merge branch 'main' of https://github.com/microsoft/AzureTRE into yuv…
yuvalyaron Aug 9, 2022
dcd279b
fix tests
yuvalyaron Aug 10, 2022
14bda58
move logic from endpoint to helper service and add tests
yuvalyaron Aug 10, 2022
da95172
add test to verify that any role that can access the 'review' endpoin…
yuvalyaron Aug 10, 2022
4cb8fcf
add tests for get_allowed_actions
yuvalyaron Aug 10, 2022
cde5a00
Merge branch 'main' of https://github.com/microsoft/AzureTRE into yuv…
yuvalyaron Aug 10, 2022
d1a584a
update api version
yuvalyaron Aug 10, 2022
5efcb14
fix typo and rename method
yuvalyaron Aug 10, 2022
1f7cc7b
update changelog
yuvalyaron Aug 11, 2022
cd3b67f
Merge branch 'main' of https://github.com/microsoft/AzureTRE into yuv…
yuvalyaron Aug 14, 2022
e6b987d
rename AirlockRequestInList to AirlockRequestWithAllowedUserActionsIn…
yuvalyaron Aug 14, 2022
abf1df4
rename get_airlock_requests_by_workspace_id to get_airlock_requests
yuvalyaron Aug 14, 2022
ede57f0
rename variables
yuvalyaron Aug 14, 2022
a39c191
Merge branch 'main' of https://github.com/microsoft/AzureTRE into yuv…
yuvalyaron Aug 14, 2022
1f93593
update api version
yuvalyaron Aug 14, 2022
4064243
change endpoint permissions to allow airlock manager to access it
yuvalyaron Aug 14, 2022
3a88367
add role dependency to dependencies
yuvalyaron Aug 14, 2022
2d4572a
add get_sample_airlock_request_with_allowed_user_actions method
yuvalyaron Aug 14, 2022
ecf7ae1
add 'submit' airlock actions
yuvalyaron Aug 15, 2022
118b7b2
combine airlock action tests
yuvalyaron Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change endpoint permissions to allow airlock manager to access it
  • Loading branch information
@yuvalyaron
yuvalyaron committed Aug 14, 2022
commit 4064243228e60cfee32e8f845b82e7659262dc58
2 changes: 1 addition & 1 deletion api_app/api/routes/airlock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ async def create_draft_request(airlock_request_input: AirlockRequestInCreate, us
async def get_all_airlock_requests_by_workspace(
airlock_request_repo=Depends(get_repository(AirlockRequestRepository)),
workspace=Depends(get_deployed_workspace_by_id_from_path),
user=Depends(get_current_workspace_owner_or_researcher_user),
user=Depends(get_current_workspace_owner_or_researcher_user_or_airlock_manager),
creator_user_id: str = None, type: AirlockRequestType = None, status: AirlockRequestStatus = None, awaiting_current_user_review: bool = None) -> AirlockRequestWithAllowedUserActionsInList:
try:
airlock_requests = get_airlock_requests_by_user_and_workspace(user=user, workspace=workspace, airlock_request_repo=airlock_request_repo,
Expand Down