Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamiclly setup diagnostic settings to support standard app-service SKU #2415

Merged

Conversation

tamirkamara
Copy link
Collaborator

Resolves #2396

What is being addressed

Some of the diagnostic settings we're turning on weren't compatible with the standard app service plan SKU

How is this addressed

  • Read the application diagnostic options in runtime and turn on what is available.

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Unit Test Results

0 tests   - 3   0 ✔️ ±0   0s ⏱️ - 47m 22s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0  - 3 

Results for commit 6606e33. ± Comparison against base commit 478e07d.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2813420680 (with refid ee86a76b)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara marked this pull request as ready for review August 8, 2022 14:04
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2818498510 (with refid ee86a76b)

(in response to this comment from @tamirkamara)

@marrobi marrobi self-requested a review August 9, 2022 08:11
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2825787606 (with refid ee86a76b)

(in response to this comment from @tamirkamara)

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with S1 and all good.

@tamirkamara tamirkamara merged commit c23f57a into main Aug 9, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2396-support-standard-app-service-plans branch August 9, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor Diagnostics Settings does not support Virus Scanning and Audit settings
2 participants