Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource processor checks its runner processes #2329

Merged
merged 8 commits into from
Jul 25, 2022
Merged

Resource processor checks its runner processes #2329

merged 8 commits into from
Jul 25, 2022

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Jul 24, 2022 •
edited
Loading

Fixes #2327

What is being addressed

We've observed situations where the resource processor main process is online and health (http returns 200) but its runner sub processes are not operational (might be related to opencensys issues).

How is this addressed

  • Add a periodic check on the sub processes. If all are down - bring the http server down as well. This will later cause VMSS to repair the instance as it will be considered unhealthy.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2726388957 (with refid beeb6968)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara linked an issue Jul 24, 2022 that may be closed by this pull request
Resource processor health should check its sub-processes #2327
Closed
1 task
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2727185191 (with refid beeb6968)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2727185191 (with refid beeb6968)

(in response to this comment from @tamirkamara)

Base automatically changed from tamirkamara/app-insights-roles to main July 25, 2022 06:18
@tamirkamara tamirkamara marked this pull request as ready for review July 25, 2022 06:27
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2730351641 (with refid beeb6968)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara requested a review from damoodamoo July 25, 2022 08:31
@github-actions
Copy link

github-actions bot commented Jul 25, 2022 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4c95370.

♻️ This comment has been updated with latest results.

damoodamoo
damoodamoo approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it!

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2733600452 (with refid beeb6968)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit eba6764 into main Jul 25, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2327-rp-health-checks-processes branch July 25, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoodamoo damoodamoo damoodamoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource processor health should check its sub-processes
2 participants
@tamirkamara @damoodamoo