Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub script to capture PR info #1713

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

stuartleeks
Copy link
Contributor

  • Capture info and dump to compare with existing method of generation
  • Update tests to create new mock per test for more reliable assertions on calls to mocks (i.e. avoid interference across tests)

Part of #1538

Future PR(s) will update the pipeline to start using the outputs from the GitHub script and remove some of the bash steps in the workflow.

Capture info and dump to compare with existing method of generation
Update tests to create new mock per test for more reliable Called assertions
@stuartleeks stuartleeks force-pushed the sl/pr-bot-calculate-sha branch from ef0ec40 to c2aa4c1 Compare April 20, 2022 14:49
Copy link
Member

@martinpeck martinpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM....just one comment on tabs, and one question

.github/scripts/build.js Outdated Show resolved Hide resolved
.github/scripts/build.js Outdated Show resolved Hide resolved
@stuartleeks
Copy link
Contributor Author

/test-force-approve

(changes not covered by /test)

@stuartleeks stuartleeks merged commit 81d10a2 into microsoft:main Apr 21, 2022
@stuartleeks stuartleeks deleted the sl/pr-bot-calculate-sha branch April 21, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants