Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy both PR and branch environments on /test-destroy-env #1663

Merged

Conversation

stuartleeks
Copy link
Contributor

Update /test-destroy-env to destroy both the PR environment (created by /test) and the branch environment (created by workflow_dispatch of deploy_tre_branch.yml) to make environment clean-up easier:

  • Don't error if environment doesn't exist in destroy_env_no_terraform.sh
  • Update pr-bot to also destory branch environment on /test-destroy-env

Part of #1538

- Don't error if environment doesn't exist in destroy_env_no_terraform.sh
- Update pr-bot to also destory branch environment on /test-destroy-env
@stuartleeks stuartleeks force-pushed the sl/destroy-branch-and-pr-envs branch from 73fa3aa to 0503590 Compare April 8, 2022 08:59
Copy link
Contributor

@tanya-borisova tanya-borisova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Didn't know that devops/scripts/destroy_env_no_terraform.sh exists -- that would have saved me some time!

@stuartleeks
Copy link
Contributor Author

/test-force-approve

changes not covered in tests

@stuartleeks stuartleeks merged commit c4a7da0 into microsoft:main Apr 8, 2022
@stuartleeks stuartleeks deleted the sl/destroy-branch-and-pr-envs branch April 8, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants