Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for GitHub script used in pr-bot #1660

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

stuartleeks
Copy link
Contributor

@stuartleeks stuartleeks commented Apr 6, 2022

Add tests for the GitHub script to help catch errors during tidy-up/refactoring for #1538

  • Initial test structure for build scripts and tests for getCommandFromComment
  • Add tests for labelAsExternalIfAuthorDoesNotHaveWriteAccess

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Unit Test Results

0 files   - 1  0 suites   - 1   0s ⏱️ - 24m 21s
0 tests  - 1  0 ✔️  - 1  0 💤 ±0  0 ±0 

Results for commit 3c5ede7. ± Comparison against base commit 21dc2ac.

This pull request removes 1 test.
test_workspace_service_creation ‑ test_create_guacamole_service_into_base_workspace

♻️ This comment has been updated with latest results.

@stuartleeks stuartleeks marked this pull request as ready for review April 7, 2022 14:56
Copy link
Contributor

@ross-p-smith ross-p-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartleeks
Copy link
Contributor Author

/test-force-approve

not covered by PR tests

@stuartleeks stuartleeks merged commit 49c6c7a into main Apr 8, 2022
@stuartleeks stuartleeks deleted the sl/pr-bot-tests branch April 8, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants