Handle non-success error codes in healthcheck #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only attempt to parse response as JSON for 200 success responses Avoids attempting to parse HTML from 502 Bad Gateway responses
|
/test |
|
/test Previous run got the |
|
/test Previous run got Gateway timeout on registering bundles |
damoodamoo
approved these changes
Apr 5, 2022
Set .gitignore in tmp folder (and remove from main gitignore) Tidy handling of showing output
|
/test |
martinpeck
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes #1593
What is being addressed
When the App Gateway returns a
502 Bad Gatewayresponse, the body is HTML rather than JSON and we get an error:parse error: Invalid numeric literal at line 1, column 7How is this addressed
This PR changes the healthcheck to only attempt to parse response as JSON for 200 success responses. This avoids attempting to parse HTML from 502 Bad Gateway responses as JSON.