Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix - Not add log processor repeatedly when there is any config warning #1377

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Bug Fix - Not add log processor repeatedly when there is any config warning #1377

merged 1 commit into from
Sep 4, 2024

Conversation

zhiyuanliang-ms
Copy link
Contributor

The attribute log processor should only be initialized once. This should be a logic bug.

@zhiyuanliang-ms
Copy link
Contributor Author

@hectorhdzg @JacksonWeber @OsvaldoRosado Could you help review this PR?

@JacksonWeber JacksonWeber self-requested a review September 4, 2024 14:36
JacksonWeber
JacksonWeber approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@JacksonWeber JacksonWeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this unnecessary re-initialization of the loggerProvider in our console warning solution. LGTM

@JacksonWeber JacksonWeber merged commit 15395d1 into microsoft:main Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacksonWeber JacksonWeber JacksonWeber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiyuanliang-ms @JacksonWeber