Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exception Handling to File Name for Telemetry Caching #1267

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Add Exception Handling to File Name for Telemetry Caching #1267

merged 9 commits into from
Feb 2, 2024

Conversation

JacksonWeber
Copy link
Contributor

@JacksonWeber JacksonWeber commented Jan 29, 2024

#1230

Append the process ID to the file name created for holding disk cached telemetry. This should resolve the issue with multiple Azure Functions cores attempting to read/write/delete the same file when functions are scaled to use multiple cores.

Extended this logic outside of Azure Functions so that in any case where the SDK could be run concurrently we create distinct cache files.

@JacksonWeber JacksonWeber changed the title Add process ID to created file name for logs caching. Add Process ID to File Name for Telemetry Caching Jan 29, 2024
Library/Sender.ts Outdated Show resolved Hide resolved
@JacksonWeber JacksonWeber changed the title Add Process ID to File Name for Telemetry Caching Add Exception Handling to File Name for Telemetry Caching Feb 2, 2024
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants