add net9 to test framework #2909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
commented
Oct 29, 2024
| @@ -143,7 +143,7 @@ private void RemoveTestEnvVarsAssociatedToModule(AppServicesHeartbeatTelemetryMo | |||
| { | |||
| foreach (var kvp in appServicesHbeatModule.WebHeartbeatPropertyNameEnvVarMap) | |||
| { | |||
| Environment.SetEnvironmentVariable(kvp.Value, string.Empty); | |||
| Environment.SetEnvironmentVariable(kvp.Value, null); | |||
There was a problem hiding this comment.
seems like there was a runtime change.
NET8 and prior expected this call to delete the Environment Variable.
One of the tests was asserting that the Environment Variable was empty.
Starting in NET9, this was setting the Environment Variable to string.Empty, causing the same test to fail.
rajkumar-rangaraj
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.